[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/10] kern/term: Make grub_getkeystatus helper funtion avail

From: Daniel Kiper
Subject: Re: [PATCH 06/10] kern/term: Make grub_getkeystatus helper funtion available everywhere
Date: Fri, 3 Apr 2020 20:17:37 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Mar 13, 2020 at 08:14:41PM +0100, Javier Martinez Canillas wrote:
> From: Hans de Goede <address@hidden>
> Move the grub_getkeystatus helper function from
> grub-core/commands/keystatus.c to grub-core/kern/term.c
> and export it so that it can be used outside of the
> keystatus command code too.
> Signed-off-by: Hans de Goede <address@hidden>
> Signed-off-by: Javier Martinez Canillas <address@hidden>

Again, why? And it would be nice if you mention in the patches like this
that the logic is unchanged.

Additionally, please put all code shuffling patches at the beginning of
the patchset.

If you do that you can add my RB.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]