[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] cmdline: pass kernel command line as verbatim

From: Daniel Kiper
Subject: Re: [PATCH] cmdline: pass kernel command line as verbatim
Date: Tue, 7 Apr 2020 12:57:56 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Mon, Apr 06, 2020 at 04:55:52PM +0800, Michael Chang wrote:
> On Mon, Apr 06, 2020 at 09:18:26AM +0200, Olaf Hering wrote:
> > Am Sat, 4 Apr 2020 13:31:40 +0800
> > schrieb Michael Chang <address@hidden>:
> >
> > >  7 files changed, 229 insertions(+), 2 deletions(-)
> >
> > A lot of churn. It is called 'verbatim', yet it inserts extra characters in 
> > the output buffer.
> What verbatim means when people read that from the manual is really not
> up to me. Here my attempt was merely to fix problem as you did but
> mostly reflecting my own point of view. Afterall the table provided in
> the description can easily be used as reason to turn down the patch if
> it really not making sense on the premise that we have agreed on a real
> fix would be looking like, be it yours, mine or anyone else's proposal.
> > I'm still stunned why there is an argument about the obvious bugfix.
> It is absolutely bugfix, however any prospective impact on grub.cfg that
> a bugfix would introduce is always a thing for upstream to adopt it.

Michael, thank you for preparing the patch.

Olaf, Michael, I chatted with Vladimir and he told me that the commit
introducing the "issue" was deliberate change. I asked him to explain
here what problem it fixes and how to fix the breakage introduced by the
fix... Yeah... :-) Sadly as he told me the issue is complicated and the
real fix is not easy. Anyway, I hope that he will be able to chime in
soon and shed more light at this long standing problem. So, finally we
will be able to provide the solution...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]