[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v3 2/5] configure: Set gnu99 C language standard by default

From: Daniel Kiper
Subject: [PATCH v3 2/5] configure: Set gnu99 C language standard by default
Date: Wed, 13 May 2020 14:02:48 +0200

Commit d5a32255d (misc: Make grub_strtol() "end" pointers have safer
const qualifiers) introduced "restrict" keyword into some functions
definitions. This keyword was introduced in C99 standard. However, some
compilers by default may use C89 or something different. This behavior
leads to the breakage during builds when c89 or gnu89 is in force. So,
let's set gnu99 C language standard for all compilers by default. This
way a bit random build issue will be fixed and the GRUB source will be
build consistently regardless of type and version of the compiler.

It was decided to use gnu99 C language standard because it fixes the
issue mentioned above and also provides some useful extensions which are
used here and there in the GRUB source. Potentially we can use gnu11
too. However, this may reduce pool of older compilers which can be used
to build the GRUB. So, let's live with gnu99 until we discover that we
strongly require a feature from newer C standard.

The user is still able to override C language standard using relevant
*_CFLAGS variables.

Signed-off-by: Daniel Kiper <address@hidden>
v3 - suggestions/fixes:
   - add a comment before the change in
     (suggested by Javier Martinez Canillas and Leif Lindholm),
   - improve commit message
     (suggested by Javier Martinez Canillas and Leif Lindholm).

v2 - suggestions/fixes:
   - unconditionally enforce gnu99 C language standard
     (suggested by Leif Lindholm).
--- | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/ b/
index b2576b013..3eda9a5a2 100644
--- a/
+++ b/
@@ -80,6 +80,12 @@ if test "x$TARGET_CFLAGS" = x; then
+# Enable support for "restrict" keyword and other
+# features from gnu99 C language standard.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]