[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [MULTIBOOT2 SPEC PATCH v3 3/4] multiboot2: Make example kernel build

From: Daniel Kiper
Subject: Re: [MULTIBOOT2 SPEC PATCH v3 3/4] multiboot2: Make example kernel build at least for i386
Date: Wed, 13 May 2020 18:24:28 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, May 08, 2020 at 06:50:48AM +0200, Hans Ulrich Niedermann wrote:
> The example kernel has assembly language boot code for both
> i386 and mips, but the mips assembly code used to be built
> unconditionally, even if the build is using non-mips build
> tools such as for x86_64 or i386.
> This makes the example kernel build at least for i386, both
> on i386 and on x86_64 hosts.
>   * renames the i386 boot code from boot.S to boot_i386.S
>     to go along with the mips boot code in boot_mips.S
>   * adds AC_CANONICAL_HOST to select the proper boot code:
>       * i386 if building on x86_64 (adds -m32) or on i[3456]86
>       * mips if building for mips*
>       * do not build the kernel if building for another system
>   * adds m4 quoting and uses AS_HELP_STRING use in
>   * fixes the name of the constants used in boot_i386.S
>     to use the actual constant names from multiboot2.h
>   * documents both boot_i386.S and boot_mips.S in the
>     multiboot.texi page

May I ask you to split this patch into logical parts?

> Building the example kernel for mips still needs some work, as
> I have not managed to build for mips yet with either my
> mips64-linux-gnu cross-compilation toolchain on Fedora 32 or
> on my Debian 10.3 MIPS install running in qemu-system-mips.

This is not big deal. We can fix it later.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]