[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] multiboot: Add support for program headers at "strange" loca

From: John Paul Adrian Glaubitz
Subject: Re: [PATCH] multiboot: Add support for program headers at "strange" locations
Date: Sat, 23 May 2020 17:37:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 5/23/20 5:30 PM, Jacob Paul via Grub-devel wrote:
> Currently, grub_multiboot_load_elf() will throw an error if the program 
> header is at a too high offset (since it would be outside the allocated 
> buffer space of MULTIBOOT_SEARCH bytes). It is understandable why it does 
> this, since 99.99% of all cases e_phoff has a value of 0x34 or 0x40. So, to 
> be able to support a (uncommon) circumstance like this, the program header 
> can be loaded into a separate buffer if needed, and then freed at the end. 
> The only downside to this is that grub_multiboot_load_elf() must at every 
> return statement check if phdr_base is a separate buffer and if so 
> de-allocate it.

I would suggest adding newlines in the description as otherwise the text might
end in one line in the actual commit message.

Although I'm not sure whether "git-am" adds automatic line breaks.


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - address@hidden
`. `'   Freie Universitaet Berlin - address@hidden
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

reply via email to

[Prev in Thread] Current Thread [Next in Thread]