[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cryptodisk: Incorrect calculation of sector in grub_cryptodi
|
From: |
Glenn Washburn |
|
Subject: |
Re: [PATCH] cryptodisk: Incorrect calculation of sector in grub_cryptodisk_read/write. |
|
Date: |
Wed, 26 Aug 2020 18:50:29 -0500 |
On Wed, 26 Aug 2020 18:44:35 -0500
Glenn Washburn <development@efficientek.com> wrote:
> Here dev is a grub_cryptodisk_t and dev->offset is offset in sectors
> of size native to the cryptodisk device. The function grub_disk_read
> expects that the given start sector is in the native grub sector
> size, so dev->offset must be converted as well. Create function
> grub_disk_from_native_sector to convert disk sectors to grub sectors.
Upon reviewing my previous patch, I realized that the updated commit
message had gotten lost. So this only changes the commit message and
not the diff itself. I don't think its imperative to have this updated
commit message, but I do think it more clearly and accurately describes
the patch.
Glenn
- Re: [PATCH 0/9] Cryptodisk fixes for v2.06, (continued)
- Re: [PATCH 0/9] Cryptodisk fixes for v2.06, Glenn Washburn, 2020/08/24
- [PATCH v2 0/9] Cryptodisk fixes for v2.06, Patrick Steinhardt, 2020/08/26
- [PATCH v2 1/9] json: Remove invalid typedef redefinition, Patrick Steinhardt, 2020/08/26
- [PATCH v2 2/9] luks: Fix out-of-bounds copy of UUID, Patrick Steinhardt, 2020/08/26
- [PATCH v2 3/9] luks2: Fix use of incorrect index and some error messages, Patrick Steinhardt, 2020/08/26
- [PATCH v2 4/9] luks2: grub_cryptodisk_t->total_length is the max number of device native sectors, Patrick Steinhardt, 2020/08/26
- [PATCH v2 5/9] luks2: Improve error reporting when decrypting/verifying key, Patrick Steinhardt, 2020/08/26
- [PATCH v2 6/9] cryptodisk: Unregister cryptomount command when removing module, Patrick Steinhardt, 2020/08/26
- [PATCH v2 7/9] cryptodisk: Fix incorrect calculation of start sector, Patrick Steinhardt, 2020/08/26
- [PATCH v2 8/9] cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain', Patrick Steinhardt, 2020/08/26
- [PATCH v2 9/9] cryptodisk: Properly handle non-512 byte sized sectors, Patrick Steinhardt, 2020/08/26
- Re: [PATCH v2 0/9] Cryptodisk fixes for v2.06, Glenn Washburn, 2020/08/26