Re: [PATCH v3 6/9] cryptodisk: Unregister cryptomount command when removing module

[Daniel Kiper]

On Mon, Sep 07, 2020 at 05:27:55PM +0200, Patrick Steinhardt wrote:
> From: Glenn Washburn <development@efficientek.com>
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>
> ---
>  grub-core/disk/cryptodisk.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
> index 1897acc4b..b2c6e9a7d 100644
> --- a/grub-core/disk/cryptodisk.c
> +++ b/grub-core/disk/cryptodisk.c
> @@ -1311,5 +1311,6 @@ GRUB_MOD_FINI (cryptodisk)
>  {
>    grub_disk_dev_unregister (&grub_cryptodisk_dev);
>    cryptodisk_cleanup ();

I am OK with this patch but I realized that cryptodisk_cleanup() body is
commented out, So, could you add another patch which drops
cryptodisk_cleanup() entirely from the GRUB code? Or make it work as it
supposed to work. Maybe the latter is better...

Daniel