[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] error: Do compile-time format string checking on grub_error.

From: Glenn Washburn
Subject: Re: [PATCH] error: Do compile-time format string checking on grub_error.
Date: Mon, 5 Oct 2020 01:12:11 -0500

On Sat, 3 Oct 2020 17:34:29 -0500
Glenn Washburn <> wrote:

> On Thu, 17 Sep 2020 16:29:23 +0200
> Daniel Kiper <> wrote:
> > On Fri, Jul 31, 2020 at 09:33:18AM -0500, Glenn Washburn wrote:
> > > Fix the many issues this uncovered mostly related to incorrect
> > > length modifiers.
> > 
> > Did you test the 32-bit and 64-bit builds with this patch?
> > 
> > Daniel
> I have tested that this patch does indeed compile on i386-pc and
> x86_64-efi. Is that what you're wondering?  Is the patch not compiling
> for you?
> You can verify that these are all issues by solely applying the patch
> to include/grub/err.h and building under a variety of target arches
> and platforms.

I notice now that both 32-bit and 64-bit builds will fail with this
patch applied to master.  This patch assumes some code changes in my
patch titled "luks2: Fix use of incorrect index and some grub_error()
messages." that has been sent to this list and changes from another
patch I forgot to include.  I'll resend the patch with the changes from
the missing patch, but still require changes from the previously
mentioned patch sent to the list.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]