[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/10] Cryptodisk fixes for v2.06 redux

From: Glenn Washburn
Subject: Re: [PATCH v3 00/10] Cryptodisk fixes for v2.06 redux
Date: Tue, 3 Nov 2020 18:50:56 +0000 (UTC)

Nov 2, 2020 9:56:58 AM Daniel Kiper <>:

> On Tue, Oct 27, 2020 at 08:25:13PM +0100, Daniel Kiper wrote:
>> On Mon, Oct 19, 2020 at 06:09:48PM -0500, Glenn Washburn wrote:
>>> Heres an updated patch series which addresses comment from Patrick. The only
>>> code change is adding a slot_key member to grub_luks2_keyslot and using that
>>> instead of an extra out parameter to luks2_get_keyslot.
>>> Glenn Washburn (10):
>>> luks2: Fix use of incorrect index and some grub_error() messages.
>>> luks2: Improve readability in luks2_get_keyslot.
>>> luks2: Use more intuitive keyslot key instead of index when naming
>>> keyslot.
>>> luks2: grub_cryptodisk_t->total_length is the max number of device
>>> native sectors
>>> cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'.
>>> cryptodisk: Properly handle non-512 byte sized sectors.
>>> cryptodisk: Replace some literals with constants in
>>> grub_cryptodisk_endecrypt.
>>> cryptodisk: Rename total_length field in grub_cryptodisk_t to
>>> total_sectors.
>>> cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors.
>>> luks2: Rename source disk variabled named 'disk' to 'source' as in
>>> luks.c.
>> Most of LUKS2 patches require rework. The rest which got Patrick's and
>> my RB I will push into the GRUB git repo by the end of this week. Of
>> course if there are no objections...
> I was only able to take 'cryptodisk: Fix cipher IV mode "plain64" always
> being set as "plain"' patch. The other patches depend on some changes in
> earlier patches in the series. So, feel free to add my RB to the patches
> which got it from me.
> Daniel

If I move the rework the rename patches to be earlier in the patch series, you 
should be able to get those in right? It's annoying to keep them in the patch 
series while reworking the other patches.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]