grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] i386-pc: build verifiers API as module


From: Colin Watson
Subject: Re: [PATCH v2] i386-pc: build verifiers API as module
Date: Mon, 22 Mar 2021 20:09:23 +0000
User-agent: Mutt/1.10.1 (2018-07-13)

On Mon, Mar 22, 2021 at 04:16:26PM +0000, Colin Watson wrote:
> On Mon, Mar 22, 2021 at 04:20:00PM +0100, Daniel Kiper wrote:
> > NAK for this patch and others "fixing" small MBR gaps. I am not going to
> > deal with this kind of issues any longer because a few folks in the
> > world cannot/do not want/... reinstall their systems. Sorry guys.
> 
> I'd just like to say that I think this is an unfortunate mistake, and
> puts distributions in an invidious position.

Additionally, it doesn't make sense to use this argument to nack
https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00271.html,
which merely makes error messages consistent across the codebase; I
might well have done that sort of cleanup on general principles.
Similarly, are you really going to refuse
https://lists.gnu.org/archive/html/grub-devel/2021-03/msg00278.html
merely because applying it would reduce the image size on i386-pc?  (I
could understand if the argument were "let's remove that code entirely
rather than ifdeffing it out ...)

A blanket nack policy for this sort of thing just doesn't seem to make
any logical sense.

-- 
Colin Watson (he/him)                              [cjwatson@debian.org]



reply via email to

[Prev in Thread] Current Thread [Next in Thread]