[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] configure: Remove obsoleted -malign-{jumps, loops, funct

From: Paul Menzel
Subject: Re: [PATCH 1/2] configure: Remove obsoleted -malign-{jumps, loops, functions}
Date: Tue, 24 Aug 2021 08:24:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

Dear Fāng-ruì,

Am 24.08.21 um 08:18 schrieb Fangrui Song via Grub-devel:
GCC warns `cc1: warning: ‘-malign-loops’ is obsolete, use ‘-falign-loops’`.
Clang silently ignores -malign-{jumps,loops,functions}.

The preferred -falign-* forms have been supported since GCC 3.2, so just
remove -malign-{jumps,loops,functions}.

In `INSTALL` under *The Requirements* at least GCC 5.1 is required.

* GCC 5.1.0 or later
  Experimental support for clang 3.8.0 or later (results in much bigger 
  for i386, x86_64, arm (including thumb), arm64, mips(el), powerpc, sparc64

So, this works.

Signed-off-by: Fangrui Song <>
--- | 9 ---------
  1 file changed, 9 deletions(-)

diff --git a/ b/
index bee28dbeb..9a12151bd 100644
--- a/
+++ b/
@@ -805,17 +805,8 @@ if test "x$target_cpu" = xi386; then
- AC_CACHE_CHECK([whether -malign-loops works], [grub_cv_cc_malign_loop], [
-    CFLAGS="$TARGET_CFLAGS -malign-loops=1 -Werror"
-        [grub_cv_cc_malign_loop=yes],
-       [grub_cv_cc_malign_loop=no])
-  ])
    if test "x$grub_cv_cc_falign_loop" = xyes; then
      TARGET_CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 
-  elif test "x$grub_cv_cc_malign_loop" = xyes; then
-    TARGET_CFLAGS="$TARGET_CFLAGS -malign-jumps=1 -malign-loops=1 

Acked-by: Paul Menzel <>

Kind regards,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]