[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_tes

From: Glenn Washburn
Subject: Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test
Date: Thu, 26 Aug 2021 17:30:48 -0500

On Thu, 26 Aug 2021 23:28:04 +0200
"Thomas Schmitt" <> wrote:

> > If yes, then I should probably remove this patch altogether and put
> > this code elsewhere.
> I think it can be justified to hardcode UTF-8 in grub-fs-tester
> regardless whether higher levels of the test empire or the user have
> own interests in locale settings.
> The code in grub-fs-tester is a good example for the situation that
> the file names on disk might belong to users with differing locales.
> We expect UTF-8 to be the common base of all those nowadays.
> So i'd vote for something like
>   if [ -n "${LANG##*UTF*}" ]; then
>      echo "NOTE: LANG=$LANG appears to not be UTF-8."
>      echo "NOTE: Setting LANG=en_US.UTF-8 to match the test file
> names." export LANG=en_US.UTF-8
>   fi
> at the start of

Sounds good to me, please add this to the patch.

> > Would you submit a patch with the changes you've
> > outlined that would fix this issue for when LANG is empty?
> I'd go farer and smack down everything that does not claim to be
> UTF-8.
> Is a git diff enough or has it to be git format-patch from a local
> commit ? Is git send-email necessary ?

I'm not sure that it has to be git format-patch then git send-email,
but that's the desired method. The following commands may help you get
to speed quickly (since its only one patch things are less complicated).

git format-patch -s <git commit hash>

Now you should have a patch file ready for sending. Setting up git
send-email isn't that hard, but I'd refer you to the man page since it
depends on your setup. Daniel might find it acceptable to send that
patch as an attachment since its just a single patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]