[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/4] cryptodisk: Remove unneeded found_uuid from cryptomou
Re: [PATCH v3 4/4] cryptodisk: Remove unneeded found_uuid from cryptomount args
Fri, 3 Dec 2021 14:29:21 +0100
On Thu, Dec 02, 2021 at 12:51:09AM -0600, Glenn Washburn wrote:
> On Thu, 18 Nov 2021 15:25:44 +0100
> Daniel Kiper <email@example.com> wrote:
> > On Tue, Oct 12, 2021 at 06:26:29PM -0500, Glenn Washburn wrote:
> > > The member found_uuid was never used by the crypto-backends, but was used
> > > to
> > Ha! Could you make this patch second in this patch series? Then we could
> > avoid carrying over have_it/found_uuid cruft over succeeding patches.
> Sure, I was avoiding do that work, but since you've requested it, I'll
> take a stab at it. I'm thinking I'll make it the first patch though, so
> its independent from the rest of the series.
If you want it to be the first I am OK with it.
> > > determine if a crypto-backend successfully mounted a cryptodisk with a
> > > given
> > > uuid. This is not needed however, because grub_device_iterate will return
> > > 1
> > > iff grub_cryptodisk_scan_device returns 1. And grub_cryptodisk_scan_device
> > s/iff/if/
> "iff" is short hand for "if and only if". I'll expand it.
Yeah, that would be better.