Re: [PATCH] Add Fedora location of DejaVu SANS font

[Nicholas Vinson]

On 12/7/21 15:04, Robbie Harwood wrote:
> Nicholas Vinson <nvinson234@gmail.com> writes:
>
> > Wouldn't it be better to modify configure.ac so the location could be
> > passed in instead of having one-off patches for alternate locations?
> > Something like --with-dejavu-font=/usr/share/fonts/dejavu-sans-fonts?
>
> That would mean that anyone using grub2 that wants the dejavu fonts will
> have to figure out that the option exists and pass it to the
> buildscripts.  That's a pretty bad user experience for anyone building
> their own grub.

On the contrary, it doesn't have to mean that at all. It could mean that 
when a path is given, configure would use the provided path; otherwise, 
it falls back to its default list to find the font. Such an approach 
would mimic configure's current behavior for values such as bootdir and 
grubdir.

> I get that maintaining a list of where everyone has put their fonts is
> somewhat obnoxious, but in the absence of a standard way of doing it,
> I'm not sure there's anything better.  The only other alternative I

See above and configure.ac's solutions to similar issues for better 
approaches.

> could think of was running find in /usr/share/fonts, which struck me as
> fraught.

Because it's the same solution you're already doing. The use of find 
won't fix anything because you'd still have to hard-code the patterns 
find uses to locate the font file.

Regards,
Nicholas Vinson

> Be well,
> --Robbie