[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/7] cryptodisk: Improve error messaging in cryptomount in
Re: [PATCH v4 3/7] cryptodisk: Improve error messaging in cryptomount invocations
Wed, 8 Dec 2021 12:28:56 -0600
On Wed, 8 Dec 2021 17:41:32 +0100
Daniel Kiper <email@example.com> wrote:
> On Sat, Dec 04, 2021 at 01:15:46AM -0600, Glenn Washburn wrote:
> > Update such that "cryptomount -u UUID" will not print two error messages
> > when an invalid passphrase is given and the most relevant error message
> > will be displayed.
> > Improve error message which is displayed when a UUID is specified, but no
> > cryptodisk backends find a disk with that UUID.
> > Also, make cryptomount return failure when no cryptodisk modules are loaded,
> > which allows an error to be displayed notifying the user that they'll want
> > to load a backend module to make cryptomount useful.
> Is it possible to split this patch into 3 separate patches?
I think the first and last hunks will be difficult to untangle, which
is part of what I expect you're asking for. The commit message has
three sections, which can be broken in to three patches easily, but two
of the patches would be fairly trivial (one is the second hunk and the
other is changing an error string to be more descriptive. Can you
clarify that I've understood you correctly and if not, give more detail
in what you're looking for?
[PATCH v4 4/7] cryptodisk: Add infrastructure to pass data from cryptomount to cryptodisk modules, Glenn Washburn, 2021/12/04
[PATCH v4 5/7] cryptodisk: Refactor password input out of crypto dev modules into cryptodisk, Glenn Washburn, 2021/12/04
[PATCH v4 6/7] cryptodisk: Move global variables into grub_cryptomount_args struct, Glenn Washburn, 2021/12/04
[PATCH v4 7/7] cryptodisk: Improve handling of partition name in cryptomount password prompt, Glenn Washburn, 2021/12/04