Re: [PATCH v4 1/2] luks, luks2: Force header.uuid to be NULL terminated

[Glenn Washburn]

On Wed, 3 Aug 2022 15:30:58 +0200
Daniel Kiper <dkiper@net-space.pl> wrote:

> On Fri, Jul 22, 2022 at 02:43:13AM -0500, Glenn Washburn wrote:
> > According to the LUKS specification the uuid header field is of data type
> > "char[]", which is defined as "a string stored as null terminated sequence
> > of 8-bit characters". So enforce this by adding a null byte as the last byte
> > of the uuid. The LUKS2 specification defers to the LUKS1 specification in
> > this regard.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> 
> In general Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...
> 
> Though I want to ask you to add a sentence to the commit message saying
> why current code works now. And a second sentence should say the part of
> existing code making it work will be removed by subsequent patch.
> Otherwise it is not really clear why this patch is needed...

Looking at this again, this patch really isn't needed in a functional
sense, with or without the following patch. I think I might have seen
this as desirable at one time because this was written before Patricks
commit 1066336d (luks: Fix out-of-bounds copy of UUID).

Its not needed for the subsequent patch because UUID comparison is
always bounded. I'll drop this change.

Glenn

> 
> Or maybe we should merge patch #1 and #2... However, I do not have strong
> opinion here.
> 
> Daniel