[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] diskfilter: check calloc() result for NULL

From: Daniel Axtens
Subject: [PATCH 1/2] diskfilter: check calloc() result for NULL
Date: Sun, 21 Aug 2022 22:22:35 +1000

With wildly corrupt inputs, we can end up trying to calloc a very
large amount of memory, which will fail and give us a NULL pointer.
We need to check that to avoid a crash. (And, even if we blocked
such inputs, it is good practice to check the results of allocations

Signed-off-by: Daniel Axtens <>
 grub-core/disk/diskfilter.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/grub-core/disk/diskfilter.c b/grub-core/disk/diskfilter.c
index 2edcff6e8987..4ac50320ef4e 100644
--- a/grub-core/disk/diskfilter.c
+++ b/grub-core/disk/diskfilter.c
@@ -1163,6 +1163,9 @@ grub_diskfilter_make_raid (grub_size_t uuidlen, char 
*uuid, int nmemb,
   array->lvs->segments->raid_member_size = disk_size;
     = grub_calloc (nmemb, sizeof (array->lvs->segments->nodes[0]));
+  if (array->lvs->segments->nodes == NULL)
+    goto fail;
   array->lvs->segments->stripe_size = stripe_size;
   for (i = 0; i < nmemb; i++)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]