Re: [PATCH] term/serial: Add support for PCI serial devices

[Peter Zijlstra]

On Thu, Aug 25, 2022 at 02:23:34PM -0500, Glenn Washburn wrote:

> > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
> > index 5212dfab1369..c0683da2353b 100644
> > --- a/grub-core/Makefile.core.def
> > +++ b/grub-core/Makefile.core.def
> > @@ -224,12 +224,14 @@ kernel = {
> >  
> >    i386_efi = kern/i386/efi/init.c;
> >    i386_efi = bus/pci.c;
> > +  i386_efi_cppflags = '-DGRUB_HAS_PCI';
> 
> I imagine this should be enabled for all i386 and x86_64 targets, not
> just the few that you have here. For instance, what about i386-pc,
> which is the 32-bit BIOS target?

So what I did was put that _cppflags thing right next to all the
'bus/pci.c' instances I found, with exception of the pci module.

Where do i386-pc and friends get it from? IOW, what obvious place did I
miss?