Re: [PATCH v5 1/5] Import libgcrypt 1.10.3

[Vladimir 'phcoder' Serbinenko]

On Thu, Sep 5, 2024 at 3:53 PM Daniel Kiper <dkiper@net-space.pl> wrote:
>
> On Tue, Sep 03, 2024 at 08:29:30PM +0300, Vladimir Serbinenko wrote:
> > We currently use an old version of libcrypt which
> > results in us having fewer ciphers and missing on many
> > other improvements.
> >
> > Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
>
> Now at least it builds but...
>
> Could you update libgcrypt to the latest version, 1.11.0?
>
Done
> When I apply the patches git complains in the following way:
> I am OK with warnings from original libgcrypt import but our patches
> should be clean.
>
Warnings come from the fact that spaces are needed in .patch files.
Otherwise they're broken.

> When I run bootstrap I can see this:
>
>   Importing libgcrypt...
>   WARNING: C file isn't a module: blake2.c
>   WARNING: C file isn't a module: ecc-curves.c
>   WARNING: C file isn't a module: ecc-ecdh.c
>   WARNING: C file isn't a module: ecc-ecdsa.c
>   WARNING: C file isn't a module: ecc-eddsa.c
>   WARNING: C file isn't a module: ecc-gost.c
>   WARNING: C file isn't a module: ecc-misc.c
>   WARNING: C file isn't a module: ecc-sm2.c
>   WARNING: C file isn't a module: gost-s-box.c
>   WARNING: C file isn't a module: poly1305.c
>   WARNING: C file isn't a module: primegen.c
>   patching file grub-core/lib/libgcrypt-grub/cipher/md.c
>   patching file grub-core/lib/libgcrypt-grub/cipher/keccak.c
>   Hunk #1 succeeded at 253 (offset 2 lines).
>
> Please fix the warnings and hunk complaint.
I silenced the warnings but they do refer to a real problem: we don't
import some of ciphers. Changed to TODO.