Re: [PATCH v2 2/2] cmdline: fix command line parsing in grub

[Vladimir 'phcoder' Serbinenko]

Here is the patch in question: https://lists.gnu.org/archive/html/grub-devel/2023-07/msg00089.html. It will need an additional change to Linux calling.

Regards
Vladimir 'phcoder' Serbinenko

Le ven. 23 mai 2025, 19:53, Shreenidhi Shedi <yesshedi@gmail.com> a écrit :

On 20/05/25 19:15, Daniel Kiper wrote:
> On Mon, May 19, 2025 at 11:49:55PM +0530, Shreenidhi Shedi wrote:
>> From: Shreenidhi Shedi <shreenidhi.shedi@broadcom.com>
>>
>> Previously, the command line construction function
>> (grub_create_loader_cmdline) escaped single and double quotes, which is
>> unnecessary and potentially problematic since the kernel command line
>> handler does not support escaped quotes. This patch removes the escaping
>> of these characters, ensuring that the constructed command line is
>> passed to the kernel as intended.
>>
>> For example:
>>
>> In /boot/grub/grub.cfg
>> ...
>> set user_cmdline="dyndbg='+p; func smp_callin -p'"
>> ...
>> menuentry "Photon" {
>>    linux /boot/$photon_linux root=$rootpartition $photon_cmdline $systemd_cmdline $user_cmdline
>>    if [ -f /boot/$photon_initrd ]; then
>>      initrd /boot/$photon_initrd
>>    fi
>> }
>> ...
>>
>> Post reboot,
>>
>> $ cat /proc/cmdline
>> ... dyndbg=\'+p; func smp_callin -p\'
>
> AFIACT Vladimir has more complete fix for this issue. I asked him to
> post it once again...
>
> Daniel

Hi Daniel,

Can you please add Vladimir to this thread? This is a regression and if
we can get a better fix, I can test it and provide an update.

--
Shedi

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel