[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gtick-devel] Tempo Names
From: |
Roland Stigge |
Subject: |
Re: [Gtick-devel] Tempo Names |
Date: |
Fri, 28 Jan 2005 15:50:48 +0100 |
Hi Marco,
On Mon, 2005-01-17 at 13:30 -0200, Marco Túlio Gontijo e Silva wrote:
> I've made a small simple patch that implements tempo names, maybe not in
> the best way.
Thanks for your patch, I reviewed it.
The po file is subject for inclusion in the next version.
For the rest, here are some comments:
* You don't need to send in gmo files since those are generated from the
po file by the build environment.
* Why do you move gtk_init() after the getopt_long() call? It's supposed
to be called upon startup _before_ getopt like calls.
* What are your motivations for the changes of the
gtk_range_set_update_policy() and gtk_range_set_increments() calls for
the scale?
Next time, please split your patch into the individual parts
(translation updates, new features, policy changes). This is much easier
to maintain.
Thanks!
bye,
Roland