[Guile-commits] branch main updated: Fix "non-revealed port is closed" ports.test

[Rob Browning]

This is an automated email from the git hooks/post-receive script.

rlb pushed a commit to branch main
in repository guile.

The following commit(s) were added to refs/heads/main by this push:
     new 6e82a4516 Fix "non-revealed port is closed" ports.test
6e82a4516 is described below

commit 6e82a4516ae597d8f1b64c2831bf14f1899f40ad
Author: Rob Browning <rlb@defaultvalue.org>
AuthorDate: Sat Sep 19 14:09:04 2020 -0500

    Fix "non-revealed port is closed" ports.test
    
    Don't close the test port's file descriptor because the port still has a
    reference to it, and could still close it at any time when finally
    garbage collected.  This did soemetimes break subsequent tests.
    
    Bug: https://debbugs.gnu.org/43521
---
 test-suite/tests/ports.test | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/test-suite/tests/ports.test b/test-suite/tests/ports.test
index cd87640ab..66e10e3dd 100644
--- a/test-suite/tests/ports.test
+++ b/test-suite/tests/ports.test
@@ -623,9 +623,10 @@
         (seek fdes 0 SEEK_CUR)
 
         ;; If we get here, it might be because PORT was not GC'd, we
-        ;; don't know (and we can't use a guardian because it would keep
-        ;; PORT alive.)
-        (close-fdes fdes)
+        ;; don't know, and we can't use a guardian because it would keep
+        ;; PORT alive, and we can't close the descriptor because
+        ;; subseuqent opens may re-use it, and then if this port is
+        ;; garbage collected, it'll close the descriptor unexpectedly.
         (throw 'unresolved))
       (lambda args
         (system-error-errno args)))))