Re: segfault in guile 1.6.7

[Kevin Ryde]

Alexey Voinov <address@hidden> writes:
>
> guile> (string-index (string (integer->char 209)) char-numeric?)
> zsh: 2760 segmentation fault  guile

Thanks.

> I haven't checked if this bug is still present in cvs HEAD.

Marius made a change that squashes it.

> Patch attached.

I'll bring across what's in the head, which is to have SCM_MAKE_CHAR
cast to an unsigned char, instead of demanding that from all callers.

--- chars.h.~1.11.4.4.~ 2004-04-25 09:25:32.000000000 +1000
+++ chars.h     2005-03-26 07:36:06.574079280 +1100
@@ -51,7 +51,7 @@
  */
 #define SCM_CHARP(x) (SCM_ITAG8(x) == scm_tc8_char)
 #define SCM_CHAR(x) ((unsigned int)SCM_ITAG8_DATA(x))
-#define SCM_MAKE_CHAR(x) SCM_MAKE_ITAG8((scm_t_bits) x, scm_tc8_char)
+#define SCM_MAKE_CHAR(x) SCM_MAKE_ITAG8((scm_t_bits) (unsigned char) (x), 
scm_tc8_char)