[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Reference leak in `iprin1 ()'

From: Neil Jerram
Subject: Re: [PATCH] Reference leak in `iprin1 ()'
Date: Sat, 12 Nov 2005 09:23:06 +0000
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

>       * print.c (EXIT_NESTED_DATA): Before popping from the stack,
>       reset the value at its top.  This fixes a reference leak.

Nice work, but it looks to me that PUSH_REF sets the value of the
(pstate->top)th element _before_ incrementing pstate->top.  So
shouldn't your fix do the decrement first and then set the slot to

(Note that your fix will still prevent most reference leaks, just not
the outermost one.  So that's why it may appear to be working

Also, is the () -> (void) change strictly related?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]