[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Inlining `scm_is_pair ()'

From: Ludovic Courtès
Subject: Re: [PATCH] Inlining `scm_is_pair ()'
Date: Fri, 27 Jan 2006 10:13:46 +0100
User-agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)

Kevin Ryde <address@hidden> writes:

> I doubt you'll ever get any feedback like that.  Making something that
> takes advantage of gcc but does no harm in vanilla c89 or c99 is in a
> sense the best of both worlds.

C99 defines `inline', so nothing wrong problem with that.  As for C89,
it would do no harm with it: the function's code will simply be
duplicated in all files that use it, except that it will not be
inlined.  At worst, some compilers may raise warnings about the function
being declared as `static' but unused.

To me, this looks acceptable.  If anyone has better suggestions, that's
cool.  But please, don't leave `scm_is_pair ()' as is.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]