Re: [PATCH] Add stack base support for Mac OS X

[Heikki Lindholm]

Kevin Ryde kirjoitti:
> Heikki Lindholm <address@hidden> writes:
>
> > This patch adds support for getting the stack base (and hence also
> > scm_init_guile()) on OS X. Tested only in one particular case I
> > needed.
>
>
> Beaut.
>
>
> > -/* pthread_getattr_np not available on MacOS X and Solaris 10. */
> > -#if HAVE_PTHREAD_ATTR_GETSTACK && HAVE_PTHREAD_GETATTR_NP
> > +/* pthread_getattr_np not available on Solaris 10. */
> > +#if (HAVE_PTHREAD_ATTR_GETSTACK && HAVE_PTHREAD_GETATTR_NP) || 
> > defined(__APPLE__)
>
>
> But hard-coding system names is bad.

Yes, but it would look worse had I tried to make it autoconf'ed with my 
limited experience. Maybe someone else can fill in that part.

> > +  return pthread_get_stackaddr_np (pthread_self ());
>
>
> Is this the operative feature, a pthread_get_stackaddr_np available?

Uh, say what?

-- Heikki Lindholm