[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Ludovic Courtès
Date: Mon, 18 Aug 2008 17:34:31 +0200
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

Hi Han-Wen,

Han-Wen Nienhuys <address@hidden> writes:

> Ludovic Courtès escreveu:

>> is kind of hard to review in a glimpse.  Does it just randomly "clean
>> things up" (whatever that means---it does not follow the GCS, for
> GCS?

"GNU Coding Standards", the thing we're supposed to adhere to when
writing code for the GNU Project:

>> instance), or does it fix anything?  It's hard to tell.  Can you
>> reproduce the heap usage graphs referred earlier in this thread?  Do
> No, the memory usage is more stable now. 

Can you show what the graph looks like, for comparison purposes?

>> you have any evidence of improved behavior?  Is it this patch that
>> triggers the assertion failure you referred to in your first message?
>> Which assertion is it that fails?
> This is fixed now.  See my message about our test-suite being broken 

Which assertion is it that failed?  Was that due to an old
`' being loaded?

> I had a look at pulling this change apart, but it is tricky since
> many of the changes are interrelated.

That's also why it's tricky to review.

> I spent more than a day writing and debugging this code - approximately
> 16 hours over the weekend.  Please keep in mind that I write serious 
> software for a living during my 40 hour work week, and don't much time
> for GUILE to spare. 

Well, I suppose most of us are in this situation, as you probably know.
That doesn't mean we never make mistakes, nor that peer review is

> If you think you need to roll back this change, please revoke my 
> commit privilege and sort things out yourself.

I tried and failed, and so did Kevin
(  AIUI,
both Kevin and I tried to identify the root of the problem (the "bug")
in a way that would allow us to fix the offending code as conservatively
as possible.

Conversely, the size and scope of your patch leaves me the impression
that you rewrote parts of the GC, without actually pinpointing what
was/is wrong with the code.  I'd have been much more confident with a
one-liner along with an explanation and sample program to determine
whether the problem is there.

> The garbage collector isn't that complicated after all.

Then the people, including me, who spent large amounts of time trying in
vain to fix the code must have been dumb.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]