[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add a `read' method for ports

From: Neil Jerram
Subject: Re: [PATCH] Add a `read' method for ports
Date: Mon, 15 Sep 2008 21:18:25 +0200

2008/9/15 Ludovic Courtès <address@hidden>:
> Hi Neil,
> "Neil Jerram" <address@hidden> writes:
>> Hopefully nearly finishing this off now...!
> Great, thanks!

OK, I've committed this now, with...

>>>> +struct port_and_swap_buffer {
>>> Please follow the GNU style.  :-)
>> Well, they say "The open-brace that starts a struct body can go in
>> column one if you find it useful to treat that definition as a
>> defun.".  Is that what you meant?
> Yes, but well...

...this opening brace moved onto the next line, but...

>>>> +  /* Reinstate the port's normal buffer. */
>>> I like adding a space after periods at the end of a sentence.
>> But there is a space there - so I don't understand!
> I meant two spaces, to distinguish periods that end a sentence from
> abbreviations.

...without an extra space here - simply because there are tons of
existing comments that end with ". */", so it doesn't seem right to
put two spaces at the end of one new comment.

I think we can treat the array handle release point separately, and
I'll follow up on that in a separate email.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]