[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e
From: |
Ludovic Courtès |
Subject: |
Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475 |
Date: |
Tue, 26 May 2009 00:22:48 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) |
Hello,
"Michael Gran" <address@hidden> writes:
> add tests for encoding/decoding wide strings
Nice!
Just a bit of cosmetic nitpicking:
> * test-suite/tests/encoding_utf8.test: new
Please use hyphens instead of underscores in file names, for
consistency.
> +(setlocale LC_ALL "en_US.utf8")
[...]
> +(setencoding "ASCII")
[...]
> +(setencoding "ISO-8859-7")
Do these modify the encoding used by the underlying port? If so, I'd
rather explicitly use a fluid, as is done for `current-reader'.
However, this relies on eval-after-read semantics. That is, if the
whole file is read at once, *then* evaluated, that won't work, right?
> +(setlocale LC_ALL "es_MX.ISO-8859-1")
Not everyone has this locale. ;-)
> +(with-test-prefix
> + "internal encoding"
> +
> + (pass-if "ultima"
> + (string=? s1 (string-ints #xfa #x6c #x74 #x69 #x6d #x61)))
Please indent as is done in other files.
Thanks!
Ludo'.
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475,
Ludovic Courtès <=
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Mike Gran, 2009/05/25
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Andy Wingo, 2009/05/26
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Mike Gran, 2009/05/26
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Andy Wingo, 2009/05/28
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Ludovic Courtès, 2009/05/28
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Andy Wingo, 2009/05/28
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Mike Gran, 2009/05/28
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Ludovic Courtès, 2009/05/28
- Re: [Guile-commits] GNU Guile branch, string_abstraction2, updated. 823e444052817ee120d87a3575acb4f767f17475, Andy Wingo, 2009/05/29