[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unicode general categories

From: Julian Graham
Subject: Re: [PATCH] Unicode general categories
Date: Thu, 24 Dec 2009 12:10:44 -0500

Hi Mike,

> Cool.  I have two very minor and pedantic suggestions.  You say that
> it will return a "one- or two-letter name".  I'm pretty sure that
> this code will always return a two-letter name and not the one-letter
> general category.

Yes, of course you're right -- uc_general_category_name operates in
terms of bits, not uc_general_category_ts returned from
uc_general_category.  The requirements for the corresponding R6RS
function confirm this as well.  I've updated the docs.

> Also, the output of SCM_CHAR is effectively a 32-bit signed int and the
> uc_general_category takes effectively a 32-bit unsigned int, so perhaps the
> cast to (int) should be left out or be libunistring's (ucs4_t) instead.
> But, of course, the code works fine as it is.

Also true -- I've taken that out (and fixed a missing `const'
specifier).  Did we turn off warnings being errors in master?  I'm
used to having my builds fail when I'm sloppy.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]