Re: Build problem & unrelated patch

[Andy Wingo]

On Fri 04 Jun 2010 06:37, No Itisnt <address@hidden> writes:

>> Here is a patch that uses AM_SILENT_RULES
>> (http://www.flameeyes.eu/autotools-mythbuster/automake/silent.html) to
>> pare down build output, and also adds some files to .gitignore. I
>> think it's a good idea.

Given that Ludovic is OK with it, and I would like to be able to do
silent rules, cool. Please repost as git commits via git-format-patch,
so we get changelogs. Some comments:

> --- a/.gitignore
> +++ b/.gitignore
> +.#*

When do you get these?

> +/lib/c++defs.h
> +/lib/iconv.h
> +/lib/netdb.h

I don't see these in my tree

> +/module/ice-9/psyntax-pp.go.*

This is a temp file, if you have it it's junk and you have to delete
manually. Not appropriate for .gitignore IMO

> +++ b/am/guilec
> @@ -30,8 +30,15 @@ install-data-hook:
>         touch -r "$$d$$p" "$(DESTDIR)$(ccachedir)/$$f"; \
>       done
>  
> +
> +GUILE_SNARF = $(top_builddir)/libguile/guile-snarf

Why GUILE_SNARF here? Shouldn't that be in am/snarf ?

The rest looks fine to me :)

Andy
-- 
http://wingolog.org/