[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Allow printing of malformed tree-il

From: Andy Wingo
Subject: Re: [PATCH] Allow printing of malformed tree-il
Date: Sat, 17 Jul 2010 14:11:04 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

On Fri 09 Jul 2010 08:23, No Itisnt <address@hidden> writes:

>> Looks good; a couple of comments inline. If you want to kill trailing
>> whitespace, though, please do that as a separate commit, without any
>> functional changes
> How do you reconcile that with 'delete-trailing-whitespace?

I don't, really. I don't use that mode. It's better to respect the
original source, so that the diffs and annotations aren't just noise...

Of course if you trawl through *my* commits, you would find
counter-examples to this "principle", so I guess there's a trade-off?

>> Here we should produce a warning, I think, even if we are
>> "permissive". Also please move the trailing parens to the previous
>> line.
> Is there a standard way to do this? Presumably it will be printed on
> *current-warning-port*, but any specific formatting guidelines or
> anything?

Unfortunately no guidelines, no. If you make some up, we'll use them
though :)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]