[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] various commenting, whitespace changes

From: Andy Wingo
Subject: Re: [PATCHES] various commenting, whitespace changes
Date: Fri, 27 Aug 2010 08:16:33 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Hi Thien-Thi,

Let me say first that I am really happy to have your energetic,
experienced hand going over Guile sources. Thank you! I do think that
small things are important, and your willingness to look at the small
*and* the big is much appreciated. It's nice to have thoughtful, local

On Fri 27 Aug 2010 01:29, Thien-Thi Nguyen <address@hidden> writes:

> I will avoid general cleanup, but i don't intend to avoid cleanup on
> files i wish to hack on (for now, this set includes makefiles, build
> scripts and documentation).

Fair enough. Please continue to separate cleanup commits from other

> I sidestepped [issues in guile-func-name-check], by rewriting in
> Scheme (and using Emacs' ‘indent-sexp’).  Unfortunately, it looks like
> hydra is not liking it:
> Perhaps a workaround would be to use ‘--no-autocompile’ in the
> invocation command (libguile/, but that seems
> ugly and throws away a bug-{hunt,squash}ing opportunity.  WDYT?

I think that not autocompiling is the right thing in this case. We don't
actually want to autocompile in Guile when, um, compiling :)

Also in the future, please run clean builds when you change invocations
of guile within libguile/.  Thanks :)

> Another related idea: Since Guile supports many languages, why not AWK?

That would be fun!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]