[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix for `submodules' in (ice-9 session) (closes #30062)

From: Jose A. Ortega Ruiz
Subject: Re: [PATCH] Fix for `submodules' in (ice-9 session) (closes #30062)
Date: Wed, 01 Sep 2010 01:11:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Hi again,

On Tue, Aug 31 2010, Jose A. Ortega Ruiz wrote:

> On Tue, Aug 31 2010, Andy Wingo wrote:
>> Hi,
>> Can you submit a test please, also?
> I'm not quite sure what you want the test to be: the procedure
> `submodules' is not exported by `(ice-9 session)', and there's no test
> suite for the latter, so testing this change properly would mean
> creating such a test suite, checking all directly affected exported
> procedures. Those are `apropos-fold-exported' and
> `apropos-fold-accessible'.
> Testing them is a bit involved, due to the cycles in the module tree

[... blah blah blah ...]

Please, ignore all the above stupid chatter. The fold functions are
already testing for duplicates and there's no infinite loop anywhere.
Sorry about my big mouth. (I'm still curious about the meaning of the
modules with gensyms as names, though.)

So, i'll write indirect tests for `submodules' by testing
`apropos-fold-exported' and `apropos-fold-all' (i didn't even get the
name right!). Would that work for you?


"I didn't do it, and I'll never do it again."
 -Derrik Weeks

reply via email to

[Prev in Thread] Current Thread [Next in Thread]