diff --git a/module/ice-9/match.scm b/module/ice-9/match.scm index 1a2a61e..b72d005 100644 --- a/module/ice-9/match.scm +++ b/module/ice-9/match.scm @@ -115,6 +115,53 @@ ((_ newpat m () v kt ke i) (syntax (match-one v newpat () kt ke i)))))) +;;Bug (match '(1 2) ((and x (a ... b)) b)) fails without the following fix +(define-syntax match-gen-ellipses + (syntax-rules () + ((_ v p () g+s (sk ...) fk i ((id id-ls) ...)) + (match-check-identifier p + ;; simplest case equivalent to (p ...), just bind the list + (let ((p v)) + (if (list? p) + (sk ... i) + fk)) + ;; simple case, match all elements of the list + (let loop ((ls v) (id-ls '()) ...) + (cond + ((null? ls) + (let ((id (reverse id-ls)) ...) (sk ... i))) + ((pair? ls) + (let ((w (car ls))) + (match-one w p ((car ls) (set-car! ls)) + (match-drop-ids (loop (cdr ls) (cons id id-ls) ...)) + fk i))) + (else + fk))))) + ((_ v p r g+s (sk ...) fk i ((id id-ls) ...)) + ;; general case, trailing patterns to match, keep track of the + ;; remaining list length so we don't need any backtracking + (match-verify-no-ellipses + r + (let* ((tail-len (length 'r)) + (ls v) + (len (length ls))) + (if (< len tail-len) + fk + (let loop ((ls ls) (n len) (id-ls '()) ...) + (cond + ((= n tail-len) + (let ((id (reverse id-ls)) ...) + (match-one ls r (#f #f) (sk ...) fk i))) + ((pair? ls) + (let ((w (car ls))) + (match-one w p ((car ls) (set-car! ls)) + (match-drop-ids + (loop (cdr ls) (- n 1) (cons id id-ls) ...)) + fk + i))) + (else + fk))))))))) + ;;We must be able to extract vars in the new constructs!! (define-syntax match-extract-vars (syntax-rules (_ ___ *** ? $ = quote quasiquote and or not get! set!) @@ -241,5 +288,5 @@ #'(begin exp ...)))))) (include-from-path/filtered - (match-extract-vars match-two match) - "ice-9/match.upstream.scm") \ No newline at end of file + (match-gen-ellipses match-extract-vars match-two match) + "ice-9/match.upstream.scm")