[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: New section "Invoking Guile" for chapter "Programming in Sche

From: Mark Harig
Subject: Re: Patch: New section "Invoking Guile" for chapter "Programming in Scheme"
Date: Mon, 25 Apr 2011 15:49:55 -0400

> > On Sun, Apr 24, 2011 at 04:33:44PM +0200, Andy Wingo wrote:
> >> your patches should be "atomic"
> >
> > "3. No patch introduces a regression: after applying any
> > initial part of the series, the resulting project still
> > compiles and works, and has no bugs that it didn’t have
> > before."
> Right, at the end of applying all of your patches, I'm sure that's the
> case; however the first patch adds an @include without adding the
> appropriate file, so applying just the first patch without the following
> two would yield a project that doesn't compile.  I just meant that you
> need to squish the first two or three of them together.  I can do that
> when I apply them, though.
> By @itemx I just meant to do instead of:
> > address@hidden -s @var{script} @var{arg...}
> you would
> @item @var{script} @var{arg...}
> @itemx -s @var{script} @var{arg}
> The other option would be
> @item [-s] @var{script} @var{arg}
> which is not as clear IMO.  I feel that it's important to have a good
> example up there, and making it clear that it's OK to just invoke Guile
> as "guile foo.scm" is important.  But your description is good too.

OK.  I have added an '@itemx' entry to distinguish between the usual
case and the special case.

> > +For compatibility with some versions of Guile 1.4, you can also use the
> > +form @code{(symbol ...)} (that is, a list of only symbols that doesn't
> > +start with @code{@@}), which is equivalent to @code{(@@ (symbol ...)
> > +main)}, or @code{(symbol ...)  symbol} (that is, a list of only symbols
> > +followed by a symbol), which is equivalent to @code{(@@ (symbol ...)
> > +symbol)}.  We recommend to use the equivalent forms directly since they
> > +correspond to the @code{(@@ ...)}  read syntax that can be used in
> > +normal code.  See @ref{Using Guile Modules} and @ref{Scripting
> > +Examples}.
> Again, probably worth eliding the deprecated 1.4 stuff...

OK.  I'm not going to change anything here (not that I disagree).
I'll leave that for someone to make a separate change.

> > address@hidden --auto-compile
> > +Compile source files automatically (default behavior).
> > +
> > address@hidden
> > +
> > address@hidden --no-auto-compile
> > +Disable automatic source file compilation.
> > +
> > address@hidden
> Need --fresh-auto-compile here too
> > address@hidden GUILE_AUTO_COMPILE
> > address@hidden GUILE_AUTO_COMPILE
> Need to note GUILE_AUTO_COMPILE=fresh, and @ref to Compilation

OK.  Added an entry to the command-line options section and updated
the description in GUILE_AUTO_COMPILE.

In order to expedite this change, I am attaching the three updated patches.

P.S., My original patch set contained two additional patches that can be
applied separately and independently.  They correct errors that I found
in unrelated files while checking the changes in this patch set.

Attachment: 0001-doc-ref-guile.texi-node-Programming-in-Scheme-Added-.patch
Description: Text Data

Attachment: 0002-doc-ref-scheme-scripts.texi-node-Guile-Scripting-Del.patch
Description: Text Data

Attachment: 0003-doc-ref-guile-invoke.texi-node-Invoking-Guile-Initia.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]