[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.2-100-g4
Re: [Guile-commits] GNU Guile branch, stable-2.0, updated. v2.0.2-100-g40bd6a7
Wed, 21 Sep 2011 12:26:54 +0200
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux)
On Wed 21 Sep 2011 11:13, address@hidden (Ludovic Courtès) writes:
> I believe that at least the <let-values> and <fix> cases are dead code
> since ‘fix-letrec!’ hasn’t been called at the point ‘peval’ is called.
For <fix>, perhaps it should be called earlier. The `let-values' case
is explicitly handled by an inlining of @call-with-values to let-values
in peval, with the goal of removing the later inlining pass, as it's not
as good as peval.
> Also, could you add tests for the new cases handled? :-) It’d make it
> easier for me to follow, and would help us not break it later.
I can try, when I have some time. Though, to disseminate the
understanding as widely as possible, perhaps I shouldn't be the one to
write those tests ;)