[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Guile-commits] GNU Guile branch, wip-compiler, updated. v2.1.0-139-

From: Ludovic Courtès
Subject: Re: [Guile-commits] GNU Guile branch, wip-compiler, updated. v2.1.0-139-gf8a333e
Date: Mon, 19 Dec 2011 00:46:13 +0100
User-agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.90 (gnu/linux)

Hi Noah,

Just a few superficial stylistic comments until I have something more
clever to say: ;-)

"Noah Lavine" <address@hidden> skribis:

>  (define default-environment
> -  `( (cons . ,(value-set-with-values 'cons))
> -     (car  . ,(value-set-with-values 'car))
> -     (cdr  . ,(value-set-with-values 'cdr))
> +  `( (cons . ,(value-set-with-values prim-cons))
> +     (car  . ,(value-set-with-values prim-car ))
> +     (cdr  . ,(value-set-with-values prim-cdr ))
>     ))

Please avoid trailing closing parenthesis.

Also, what about “vset” or just “set” instead of “value-set”?

> +              (set! (a-verify-exps ret)
> +                    (map (lambda (x) (rec ret x env)) args))
> +              ret))

Please privilege a functional style, as much as possible (in some cases
we lack the tools to do better, so that’s fine.)

> +(pass-if "value-set-can-be-anything?"
> +         (value-set-can-be-anything? anything))

In Emacs you can (put 'pass-if 'scheme-indent-function 1) to get the
“right” indentation.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]