[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix search_path to fill stat_buf when given an absolute path
From: |
Andy Wingo |
Subject: |
Re: [PATCH] Fix search_path to fill stat_buf when given an absolute pathname |
Date: |
Wed, 01 Feb 2012 23:04:35 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
On Wed 01 Feb 2012 22:47, Mark H Weaver <address@hidden> writes:
> The problem is that there's a case when 'search_path' leaves the
> 'stat_buf' uninitialized. If the provided 'filename' is an absolute
> pathname, then it simply returns this pathname unchanged without
> touching the 'stat_buf'. This is bad, because 'scm_primitive_load_path'
> proceeds to pass this uninitialized 'stat_buf' to 'compiled_is_fresh'.
Wow. What a hairy function. Thanks again for really diving in here.
The patch looks fine to me; clearly stat_buf should be filled in that
case. Please push!
I (for one) am very happy to comment on patches :) If at any time you
want comments from folks, please do continue to mail patches to the
list. But, for patches that you consider to be obviously correct,
please feel free to use your judgment as to whether to push directly or
not. Anyway, as you like :-)
Cheers,
Andy
--
http://wingolog.org/