[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: guile --listen fix

From: Mark H Weaver
Subject: Re: guile --listen fix
Date: Mon, 01 Oct 2012 01:31:23 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.7) Gecko/20120922 Icedove/10.0.7

On 09/19/2012 03:59 PM, Ian Price wrote:
Mark H Weaver<address@hidden>  writes:

Your fixes look good to me.  It would be good to add tests for the
listen option also.

(system repl server) does need tests, no question. But, I'm not sure how
I would test the command-line stuff. I suppose we could run a guile
instance with various arguments, have it output relevant variables, and
check the output. Hmm. This seems like it would be problematic with
--listen though, since we'd need to run two instances, and make some
visible changes to the instance. Maybe I just haven't thought it through

I agree that it's not trivial to implement these tests. We shouldn't let this get in the way of committing your fix, which is clearly important. Since there have been no objections, I think you should go ahead and commit it to the stable-2.0 branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]