[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] do not augment environment

From: Bruce Korb
Subject: Re: [PATCH] do not augment environment
Date: Mon, 01 Oct 2012 07:24:00 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0

Hi Mark,

On 09/30/12 19:38, Mark H Weaver wrote:
> Thanks for the patch, but I think it needs more work before it can be
> committed.  See below for my comments.

You're welcome!  Just FYI, I've got no ego wrapped up in being the
one to type in characters, so fixing things up for preferred style
or oversights would be no concern to me at all.

> * You assume that the directory separator is '/'.

Either that, or a wrapper environment fixes it up.
If there is a conventional way of dealing with Microsoft-did-it-their-way
issues, I don't know what it is.  I'm not overly familiar with Guile code.

> * You should not do the extra search if 'fname' is an absolute
>   pathname, and I'm not sure whether it should be done for relative
>   pathnames containing directory separators.  Does anyone else have
>   thoughts on that?

It is already an "unusual case" path.  The extra check would save a few cpu
cycles when the unusual case was going to fail.  This saves one or two cycles
in the marginally more common case of the unusual case succeeding.

> * As a stylistic issue, I don't like your trick of breaking out of the
>   do-while.  I'd prefer something closer to this (but with the above
>   problems addressed):

I consider it a developed style. :) The deeper the logic nesting, the
more complex the code, to my eyes anyway.  In this particular case,
we're talking about "break" in the third level instead of two statements.
I definitely think the two statements make for microscopically more
complex code.  That is likely much outweighed by familiarity with
the technique.

All that notwithstanding, it's your code and what I provided I considered
mostly a guideline for what needs to happen to eliminate the LD_LIBRARY_PATH
fiddling.  Just let me know how to plug in the Microsoft directory
separator when needed and I'll resubmit the patch.  NOTE:  I'll be out
of town the 10th through 20th.

Thanks - Bruce

reply via email to

[Prev in Thread] Current Thread [Next in Thread]