[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] In string-split, add support for character sets and predicat
From: |
Mark H Weaver |
Subject: |
Re: [PATCH] In string-split, add support for character sets and predicates. |
Date: |
Wed, 10 Oct 2012 03:59:15 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Daniel Hartwig <address@hidden> writes:
> One final thing before I resubmit. I just notice that most of this
> file has uses hard tabs, though there are places with soft. Is it
> preferable to change the patch to also use hard tabs?
IMO, even when editing code that currently uses hard tabs, all new lines
should use soft tabs, and ideally all *changed* lines should also be
converted to soft tabs. Makefiles are a special case of course.
Hard tabs cause several problems, e.g. messed up indentation in patches,
even if the file uses hard tabs consistently. Personally, I'd like to
work toward a future with no soft tabs, even if it excerbates the messed
up indentation problem in the short term.
What do you think?
Mark
PS: I recommend setting 'indent-tabs-mode' to nil in Emacs.
- [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/08
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/08
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/08
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/09
- Re: [PATCH] In string-split, add support for character sets and predicates.,
Mark H Weaver <=
- Re: [PATCH] In string-split, add support for character sets and predicates., Ludovic Courtès, 2012/10/10
- Re: [PATCH] In string-split, add support for character sets and predicates., Daniel Hartwig, 2012/10/12
- Re: [PATCH] In string-split, add support for character sets and predicates., Mark H Weaver, 2012/10/12
- Re: [PATCH] In string-split, add support for character sets and predicates., Ludovic Courtès, 2012/10/10