[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Per-port read options, reader directives, SRFI-105

From: Ludovic Courtès
Subject: Re: [PATCH] Per-port read options, reader directives, SRFI-105
Date: Tue, 23 Oct 2012 22:44:54 +0200
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux)

Hi Mark,

Thanks for splitting your work into small patches!

Mark H Weaver <address@hidden> skribis:

> From 41e550e653d6a6a3793741b1fd19e6b569cdf1ce Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Mon, 22 Oct 2012 23:23:45 -0400
> Subject: [PATCH 1/9] Move array reader from arrays.c to read.c
> * libguile/arrays.c (read_decimal_integer): Move to read.c.
>   (scm_i_read_array): Remove.  Incorporate the code into the
>   'scm_read_array' static function in read.c.
> * libguile/arrays.h (scm_i_read_array): Remove prototype.
> * libguile/read.c (read_decimal_integer): Move here from read.c.
>   (scm_read_array): Incorporate the code from 'scm_i_read_array'.  Call
>   'scm_read_vector' and 'scm_read_sexp' instead of 'scm_read'.

OK for me.  Minor remarks:

> +/* Read an array.  This function can also read vectors and uniform
> +   vectors.  Also, the conflict between '#f' and '#f32' and '#f64' is
> +   handled here.
> +
> +   C is the first character read after the '#'.
> +*/

Can you take this as an opportunity to fix the format of comments (no */
on a line of its own)?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]