Re: [PATCH] Per-port read options, reader directives, SRFI-105

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> From 2ee3bdba0ae59e6f52a9fde61ac24f219db158fa Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Tue, 23 Oct 2012 00:58:38 -0400
> Subject: [PATCH 8/9] Implement #!fold-case and #!no-fold-case reader
>  directives.
>
> * libguile/read.c (set_per_port_case_insensitive_p): New internal static
>   function.
>
>   (scm_read_shebang): Handle #!fold-case and #!no-fold-case.
>
> * doc/ref/api-evaluation.texi (Case Sensitivity, Scheme Read): Document
>   #!fold-case and #!no-fold-case reader directives.
>
> * test-suite/tests/reader.test ("per-port-read-options"): Add tests.

OK.

> +read options on a per-port basis.  Currently, the only read option that
> +is overridden in this way is the @code{case-insensitive} option, which

Instead of “Currently, the only...”, perhaps “For instance, the
@code{case-insensitive} option can be...”?

> +/* Set case-insensitivity on a per-port basis. */
> +static void
> +set_per_port_case_insensitive_p (SCM port, scm_t_read_opts *opts, int value)

Comment: Set OPTS and PORT’s case-insensitivity according to VALUE.

Ludo’.