Re: [PATCH] Futures: Avoid creating the worker pool more than once

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> address@hidden (Ludovic Courtès) writes:
>
>> Mark H Weaver <address@hidden> skribis:
>>
>>> +  ;; setting 'create-workers!' to a no-op is an optimization, but it is
>>> +  ;; still possible for '%create-workers!' to be called more than once
>>> +  ;; from different threads.  Therefore, to avoid creating %workers more
>>> +  ;; than once (and thus creating too many threads), we check to make
>>> +  ;; sure %workers is empty within the critical section.
>>
>> Do you have a scenario where this happens?
>
> I'd hoped that the comment above was clear, but let me try again.

Yes, what wasn’t clear to me is how practical this is, and whether
somebody encountered that situation in real life.

Anyway, please apply.

Thanks,
Ludo’.