[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Colorized REPL

From: Daniel Hartwig
Subject: Re: [PATCH] Colorized REPL
Date: Sat, 12 Jan 2013 09:01:29 +0800

On 11 January 2013 18:40, Nala Ginrut <address@hidden> wrote:
> Yes, that's a good point, and the test case could move out of the module
> itself.

It should.

>> I suppose the original comments were not so clear.  It is not only the
>> string but other members such as “data” that do not fit the concept of
>> “colour scheme”.  Anyway, given that it is an internal type there is
>> not much point to restructuring it all, except for pedantics.
> Well, if it's too uncomfortable, maybe it should rename to
> "colorize-context". Anyway, I agree with your opinion, it's not so
> important for an internal type.

To get it included with Guile, I believe you will have to separate it.
 With a little work there wouldn't be any use for color-scheme or
whatever anyway.

> If the Array is the only problem, we'd better fix it anyway. I think
> there's no other bad thing left, or not?

It is more than the treatment of array.  There are still Ludo's
comments about style and consistency with the rest of Guile's
codebase.  The overall structure leaves something to desire (IMO). …

Anyway, it does what it aims to do.  So that is nice. :-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]