[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Loading a module before and after adding a load path

From: Ludovic Courtès
Subject: Re: Loading a module before and after adding a load path
Date: Mon, 21 Jan 2013 18:20:17 +0100
User-agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux)

Andy Wingo <address@hidden> skribis:

> On Sat 19 Jan 2013 05:32, Noah Lavine <address@hidden> writes:
>> In the long term, Andy and Ludo, what is the right way to fix this?
> This bug was introduced here:
>     commit 0fb81f95b0222c5ba49efd3e36cf797df54c0863
>     Author: Andy Wingo <address@hidden>
>     Date:   Wed Jun 3 09:48:16 2009 +0200
>     add exception_on_error optional arg to primitive-load-path
> Before, "didit" would be #f after a failed primitive-load-path, and
> afterwards control proceeded to set it to #t.

Good catch!

> From 611e4d12abe5305b14ae24e4f135d5fc57ce0e9a Mon Sep 17 00:00:00 2001
> From: Andy Wingo <address@hidden>
> Date: Sun, 20 Jan 2013 19:33:42 +0100
> Subject: [PATCH] fix try-module-autoload, which did not detect failure to
>  find the file
> * libguile/load.c (scm_primitive_load_path): If the second argument is a
>   procedure, call it like a thunk.
> * doc/ref/api-evaluation.texi (Load Paths): Update docs.
> * module/ice-9/boot-9.scm (resolve-interface): Use `unless'.
>   (try-module-autoload): Use the new primitive-load-path to detect
>   failure to find an appropriate file.  Fixes a bug reported by Diogo
>   F. S. Ramos.  Thanks to Noah Lavine for tracking it down.

Looks good to me.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]