[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Move slow path out of 'scm_get_byte_or_eof' et al
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Move slow path out of 'scm_get_byte_or_eof' et al |
Date: |
Wed, 03 Apr 2013 10:12:59 +0200 |
User-agent: |
Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.3 (gnu/linux) |
Mark H Weaver <address@hidden> skribis:
> Fair enough. First of all, this patch reduces the size of the built
> libguile.so by about 42 kilobytes, and libguile.a by about 96 kilobytes.
>
> As for performance: the updated patches (attached below) slows things
> down by about one quarter of one percent on my machine. The specific
> benchmark I did was to call 'read-string' on an 11 megabyte ASCII text
> file, with the port-encoding set to UTF-8. In this case, all the reads
> are done using 'scm_get_byte_or_eof' (called from 'get_utf8_codepoint').
OK. Interesting.
> I've attached the new patches. Okay to push now?
Yes!
Thanks for the analysis,
Ludo’.