[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add procedures to convert alists into hash tables

From: Chris K. Jester-Young
Subject: Re: [PATCH] Add procedures to convert alists into hash tables
Date: Mon, 28 Oct 2013 08:17:57 -0400
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Oct 21, 2013 at 11:03:41PM -0400, David Thompson wrote:
> Thank you for taking the time to give some really useful feedback,
> Mark Weaver. I appreciate it.

He always writes really detailed reviews, which I highly appreciate. :-)

On which note, I have an additional nitpick:

> * libguile/hashtab.h (scm_alist_to_hash_table, scm_alist_to_hashq_table,
>   scm_alist_to_hashv_table, scm_alist_to_hashx_table): New prototypes.
> * libguile/hashtab.c (scm_alist_to_hash_table, scm_alist_to_hashq_table,
>   scm_alist_to_hashv_table, scm_alist_to_hashx_table): New procedures.
>   (SCM_ALIST_TO_HASH_TABLE): New macro.

In the GNU ChangeLog format, when you have a list of functions that
exceed one line, you should close parens at the end of each line and
reopen on the next. Thus:

* libguile/hahstab.c (scm_alist_to_hash_table, scm_alist_to_hashq_table)
  (scm_alist_to_hashv_table, scm_alist_to_hashx_table): New procedures.

> Good to know. Still trying to get used to this commit format.

If you're talking about the commit message format, we largely follow the
GNU ChangeLog format, which is described here:


reply via email to

[Prev in Thread] Current Thread [Next in Thread]