[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add procedures to convert alists into hash tables

From: David Thompson
Subject: Re: [PATCH] Add procedures to convert alists into hash tables
Date: Mon, 28 Oct 2013 19:51:43 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9

On 10/28/2013 08:17 AM, Chris K. Jester-Young wrote:
> On Mon, Oct 21, 2013 at 11:03:41PM -0400, David Thompson wrote:
>> Thank you for taking the time to give some really useful feedback,
>> Mark Weaver. I appreciate it.
> He always writes really detailed reviews, which I highly appreciate. :-)
> On which note, I have an additional nitpick:
>> * libguile/hashtab.h (scm_alist_to_hash_table, scm_alist_to_hashq_table,
>>   scm_alist_to_hashv_table, scm_alist_to_hashx_table): New prototypes.
>> * libguile/hashtab.c (scm_alist_to_hash_table, scm_alist_to_hashq_table,
>>   scm_alist_to_hashv_table, scm_alist_to_hashx_table): New procedures.
>>   (SCM_ALIST_TO_HASH_TABLE): New macro.
> In the GNU ChangeLog format, when you have a list of functions that
> exceed one line, you should close parens at the end of each line and
> reopen on the next. Thus:
> * libguile/hahstab.c (scm_alist_to_hash_table, scm_alist_to_hashq_table)
>   (scm_alist_to_hashv_table, scm_alist_to_hashx_table): New procedures.
>> Good to know. Still trying to get used to this commit format.
> If you're talking about the commit message format, we largely follow the
> GNU ChangeLog format, which is described here:
> Cheers,
> Chris.

Thank you, Chris. I'll try my best to follow the GNU ChangeLog format in
the future.

Attached is a patch with an amended commit message.

- Dave

Attachment: 0001-Add-procedures-to-convert-alists-into-hash-tables.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]